[ 
https://issues.apache.org/jira/browse/HDFS-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244921#comment-13244921
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-3000:
----------------------------------------------

> I tried to do this, but it's not as easy as it seems since 
> DistributedFileSystem is taking care of a bunch of path handling. ... are you 
> OK leaving it as is, Nicholas?

Sure.  If it is too hard, let's leave it for now and make the improvement later.

+1 patch looks good.  Some minor comments which could be fixed here or later.

- "quota (count of files and directories)" => "namespace quota (count of name 
objects including files, directories and symlinks)"

- "space quota (size of files and directories) for a directory." => "disk space 
quota (size of files) for a directory.  Note that directories and symlinks do 
not occupy disk space.

- You may want to put the following in one line.
{code}
 public HdfsAdmin(URI uri, Configuration conf)
      throws IOException {
{code}

- Remove "throws IOException" from TestHdfsAdmin.shutDownCluster().

                
> Add a public API for setting quotas
> -----------------------------------
>
>                 Key: HDFS-3000
>                 URL: https://issues.apache.org/jira/browse/HDFS-3000
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs client
>    Affects Versions: 2.0.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HDFS-3000.patch, HDFS-3000.patch, HDFS-3000.patch, 
> HDFS-3000.patch
>
>
> Currently one can set the quota of a file or directory from the command line, 
> but if a user wants to set it programmatically, they need to use 
> DistributedFileSystem, which is annotated InterfaceAudience.Private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to