[
https://issues.apache.org/jira/browse/HDFS-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246501#comment-13246501
]
Eli Collins commented on HDFS-3102:
-----------------------------------
Two minor comments, otherwise looks excellent
- Since initializeSharedEdits swallows most IOEs and returns a boolean I'd
update the throws javadoc to indicate an IOE isn't throw for most error cases.
Or perhaps swallow the IOE from unlockAll and return false tehre as well
- Good to add a test that the force option works, specifically w/o specifying
it we don't blow away your existing shared edits dirs. The code obviously looks
correct but this would be a bad bug to introduce so worth checking
> Add CLI tool to initialize the shared-edits dir
> -----------------------------------------------
>
> Key: HDFS-3102
> URL: https://issues.apache.org/jira/browse/HDFS-3102
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ha, name-node
> Affects Versions: 0.24.0, 2.0.0
> Reporter: Todd Lipcon
> Assignee: Aaron T. Myers
> Attachments: HDFS-3102.patch, HDFS-3102.patch
>
>
> Currently in order to make a non-HA NN HA, you need to initialize the shared
> edits dir. This can be done manually by cping directories around. It would be
> preferable to add a "namenode -initializeSharedEdits" command to achieve this
> same effect.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
