[
https://issues.apache.org/jira/browse/HDFS-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246940#comment-13246940
]
Aaron T. Myers commented on HDFS-3202:
--------------------------------------
Thanks a lot for the quick review, Suresh.
bq. I think this is trivial enough and unit test is an overkill.
OK, works for me. Writing a proper test here would probably require somehow
recompiling and forking a new JVM, etc. which I agree doesn't seem worth it.
bq. One quick comment - do we need second variant of the NamespaceInfo
constructor? If it is not used at many places, can we just have one constructor?
This variant is currently used in 7 places - 4 in tests and 3 in functional
areas of the code. I'm inclined to leave it as-is. Is that OK by you, Suresh?
> NamespaceInfo PB translation drops build version
> ------------------------------------------------
>
> Key: HDFS-3202
> URL: https://issues.apache.org/jira/browse/HDFS-3202
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Attachments: HDFS-3202.patch
>
>
> The PBHelper#convert(NamespaceInfoProto) function doesn't pass the build
> version from the NamespaceInfoProto to the created NamespaceInfo object.
> Instead, the NamespaceInfo constructor gets the build version using the
> static function Storage#getBuildVersion. DNs also use this static function to
> determine their own build version. This means that the check the DN does to
> compare its own build version to that of the NN always passes, regardless of
> what build version exists on the NN.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
