[ 
https://issues.apache.org/jira/browse/HDFS-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-3204:
----------------------------------

    Attachment: HDFS-3204.txt

Updated patch with comments addressed. Additional changes:
# Removed printing exception trace in BackupImage.java. While debugging it 
threw me off, as I interpreted as error.
# Failure is due to BackupNode checking the rpc server address. I do not think 
it is useful for couple of reasons. There is already an extensive test for 
checking clusterID, namespaceID etc. Also the removed check was only made in 
journal() method call and not in startLogSegment()
# Given the changes, journal method calls are verified for namespaceID, cluster 
and version match. Dropping cTime matching.

                
> Minor modification to JournalProtocol.proto to make it generic
> --------------------------------------------------------------
>
>                 Key: HDFS-3204
>                 URL: https://issues.apache.org/jira/browse/HDFS-3204
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Suresh Srinivas
>         Attachments: HDFS-3204.txt, HDFS-3204.txt
>
>
> JournalProtocol.proto uses NamenodeRegistration in methods such as journal() 
> for identifying the source. I want to make it generic so that the method can 
> be called with journal information to identify the journal. I plan to use the 
> protocol also for sync purposes, where the source of the journal can be some 
> thing other than namenode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to