[ 
https://issues.apache.org/jira/browse/HDFS-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250155#comment-13250155
 ] 

Colin Patrick McCabe commented on HDFS-3055:
--------------------------------------------

> can you explain the changes in FSNamesystem.java?

That change fixes error handling in FSNamesystem.  Previously, we did not call 
FSNamesystem::shutdown() when initialization failed.  This led to the MBeans 
staying registered.  This is irrelevant when running the NameNode normally, 
since the MBeans are destroyed when the entire process goes away.  However, 
when run from a test context, the next attempt to create a MiniDFSCluster 
instance will fail with "port in use" or some such error.

> Can you update the logging in the test cases to use 
> StringUtils.stringifyException to match trunk?

Ok.

> Did you run all the existing tests in branch-1?

I ran these tests:
TestCheckpoint,
TestEditLog,
TestNameNodeRecovery,
TestEditLogLoading,
TestNameNodeMXBean,
TestSaveNamespace,
TestSecurityTokenEditLog,
TestStorageDirectoryFailure,
TestStorageRestore
                
> Implement recovery mode for branch-1
> ------------------------------------
>
>                 Key: HDFS-3055
>                 URL: https://issues.apache.org/jira/browse/HDFS-3055
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>             Fix For: 1.0.0
>
>         Attachments: HDFS-3055-b1.001.patch, HDFS-3055-b1.002.patch, 
> HDFS-3055-b1.003.patch, HDFS-3055-b1.004.patch, HDFS-3055-b1.005.patch
>
>
> Implement recovery mode for branch-1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to