[
https://issues.apache.org/jira/browse/HDFS-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251253#comment-13251253
]
Hadoop QA commented on HDFS-3249:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522182/hdfs-3249.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/2246//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2246//console
This message is automatically generated.
> Use ToolRunner.confirmPrompt in NameNode
> ----------------------------------------
>
> Key: HDFS-3249
> URL: https://issues.apache.org/jira/browse/HDFS-3249
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Attachments: hdfs-3249.txt
>
>
> One of the recent patches in common copied NameNode.confirmPrompt to be part
> of ToolRunner, so it's available as utility code. We should now use this
> utility function from within NameNode.java instead of having two copies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
