[ 
https://issues.apache.org/jira/browse/HDFS-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252023#comment-13252023
 ] 

Eli Collins commented on HDFS-2799:
-----------------------------------

- Both getCheckpointEditsDirs and getCheckpointDirs need to be fixed (these are 
the last two uses of getStringCollection in hdfs)
- Agree w Harsh that it should use getTrimmedStringCollection directly to be 
consistent with the rest of the code
- Good test for this would be to have a test that adds space or new line to 
each config value that has a csv list of directories and tries to start a mini 
cluster (for an example of setting new values for directories checkout 
TestNameEditsConfigs)
                
> Trim fs.checkpoint.dir values
> -----------------------------
>
>                 Key: HDFS-2799
>                 URL: https://issues.apache.org/jira/browse/HDFS-2799
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.0
>            Reporter: Eli Collins
>              Labels: noob
>         Attachments: HDFS-2799.patch
>
>
> fs.checkpoint.dir values need to be trimmed like dfs.name.dir and 
> dfs.data.dir values so eg the following works. This currently results in the 
> directory "HADOOP_HOME/?/home/eli/hadoop/dirs3/dfs/chkpoint1" being created.
> {noformat}
>   <property>
>     <name>fs.checkpoint.dir</name>
>      <value>
> /home/eli/hadoop/dirs3/dfs/chkpoint1,
> /home/eli/hadoop/dirs3/dfs/chkpoint2
>      </value>
>   </property>
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to