[
https://issues.apache.org/jira/browse/HDFS-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252683#comment-13252683
]
Eli Collins commented on HDFS-3259:
-----------------------------------
ATM, aside from Todd's comments:
- I'd pull the copying from initializeSharedEdits out to a separate method
- Nit, would say "populate" instead of "initialize" since we format the shared
dir above
- Feel free to punt this to another jir: how about an end-to-end test that:
-- Starts w/ non HA NN1
-- Shutdown, enable HA on NN1, add SBN NN2
-- Run initializeSharedEdits
-- Start and transition to active NN1
-- Run bootstrapStandby
-- Confirm NN1 and NN2 are up and HA
Otherwise looks great
> NameNode#initializeSharedEdits should populate shared edits dir with edit log
> segments
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3259
> URL: https://issues.apache.org/jira/browse/HDFS-3259
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ha, name-node
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Attachments: HDFS-3259.patch, HDFS-3259.patch, HDFS-3259.patch,
> HDFS-3259.patch
>
>
> Currently initializeSharedEdits formats the shared dir so that subsequent
> edit log segments will be written there. However, it would be nice to
> automatically populate this dir with edit log segments with transactions
> going back to the last fsimage.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
