[
https://issues.apache.org/jira/browse/HDFS-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon updated HDFS-3280:
------------------------------
Attachment: hdfs-3280.txt
Trivial patch should fix the issue. I'll verify with an HLog benchmark on a
cluster as well.
This is definitely correct since the method is just a one-line call to another
method which is unsynchronized.
> DFSOutputStream.sync should not be synchronized
> -----------------------------------------------
>
> Key: HDFS-3280
> URL: https://issues.apache.org/jira/browse/HDFS-3280
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Attachments: hdfs-3280.txt
>
>
> HDFS-895 added an optimization to make hflush() much faster by
> unsynchronizing it. But, we forgot to un-synchronize the deprecated
> {{sync()}} wrapper method. This makes the HBase WAL really slow on 0.23+
> since it doesn't take advantage of HDFS-895 anymore.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
