[
https://issues.apache.org/jira/browse/HDFS-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259887#comment-13259887
]
Steve Loughran commented on HDFS-2492:
--------------------------------------
I'm +1 for this going in to trunk and 2.0; the test is that none of the minidfs
tests fail.
> BlockManager cross-rack replication checks only work for ScriptBasedMapping
> ---------------------------------------------------------------------------
>
> Key: HDFS-2492
> URL: https://issues.apache.org/jira/browse/HDFS-2492
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 1.0.1, 1.0.2, 2.0.0, 3.0.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HDFS-2492-blockmanager.patch,
> HDFS-2492-blockmanager.patch, HDFS-2492-blockmanager.patch,
> HDFS-2492-blockmanager.patch, HDFS-2492-blockmanager.patch,
> HDFS-2492-blockmanager.patch, HDFS-2492.patch
>
>
> The BlockManager cross-rack replication checks only works if script files are
> used for replication, not if alternate plugins provide the topology
> information.
> This is because the BlockManager sets its rack checking flag if there is a
> filename key
> {code}
> shouldCheckForEnoughRacks =
> conf.get(DFSConfigKeys.NET_TOPOLOGY_SCRIPT_FILE_NAME_KEY) != null;
> {code}
> yet this filename key is only used if the topology mapper defined by
> {code}
> DFSConfigKeys.NET_TOPOLOGY_NODE_SWITCH_MAPPING_IMPL_KEY
> {code}
> is an instance of {{ScriptBasedMapping}}
> If any other mapper is used, the system may be multi rack, but the Block
> Manager will not be aware of this fact unless the filename key is set to
> something non-null
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
