[
https://issues.apache.org/jira/browse/HDFS-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263873#comment-13263873
]
Daryn Sharp commented on HDFS-3331:
-----------------------------------
A few general, and probably trivial, questions: Should
{{checkSuperuserPrivilege}} be called before {{checkOperation}}? It seems more
logical that a non-admin should be rejected immediately instead of sometimes
seeing an error that an admin would see.
{{checkOperation}} for {{finalizeUpgrade}} is moved from {{NameNodeRpcServer}}
into {{FSNamesystem}}. On the surface, there doesn't appear to be consistency
between where (rpc server or namesystem) the operation is checked. Is it
intentional for {{finalizeUpgrade}} to be different than the other methods
changed in this patch?
Also involving {{FSNameSystem.finalizeUpgrade}}, I'm curious if there's a
reason why the operation and admin checks are performed within the write lock?
> Some admin methods in NN do not checkSuperuserPrivilege
> -------------------------------------------------------
>
> Key: HDFS-3331
> URL: https://issues.apache.org/jira/browse/HDFS-3331
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3331_20120426.patch
>
>
> - setBalancerBandwidth and refreshNodes should checkSuperuserPrivilege
> - finalizeUpgrade should acquire the write lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
