[
https://issues.apache.org/jira/browse/HDFS-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267124#comment-13267124
]
Hudson commented on HDFS-3330:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2194 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2194/])
HDFS-3330. If GetImageServlet throws an Error or RTE, response should not
have HTTP "OK" status. Contributed by Todd Lipcon. (Revision 1333286)
Result = ABORTED
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333286
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/CheckpointFaultInjector.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/GetImageServlet.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
> If GetImageServlet throws an Error or RTE, response has HTTP "OK" status
> ------------------------------------------------------------------------
>
> Key: HDFS-3330
> URL: https://issues.apache.org/jira/browse/HDFS-3330
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: hdfs-3330.txt
>
>
> Currently in GetImageServlet, we catch Exception but not other Errors or
> RTEs. So, if the code ends up throwing one of these exceptions, the
> "response.sendError()" code doesn't run, but the finally clause does run.
> This results in the servlet returning HTTP 200 OK and an empty response,
> which causes the client to think it got a successful image transfer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
