[ 
https://issues.apache.org/jira/browse/HDFS-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267130#comment-13267130
 ] 

Aaron T. Myers commented on HDFS-3351:
--------------------------------------

bq. Patch looks good. +1. Nice job, Aaron "De Morgan" Myers.

Conjunctions and disjunctions are my jam.

bq. What was the user-visible impact of this, if any?

Your NameNode would not start in a non-HA, non-Federated environment unless the 
values of fs.defaultFS and dfs.namenode.rpc-address were the same in the NN 
conf. I encountered this because I wanted to test ViewFS in a non-federated 
cluster and I wanted the fs.defaultFS to be viewfs://...

I'm going to commit this momentarily.
                
> NameNode#initializeGenericKeys should always set fs.defaultFS regardless of 
> whether HA or Federation is enabled
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3351
>                 URL: https://issues.apache.org/jira/browse/HDFS-3351
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.0.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HDFS-3351.patch
>
>
> NameNode#initializeGenericKeys exits early if neither a nameservice nor NN ID 
> is passed. However, this method also serves to set fs.defaultFS in the 
> configuration object stored by the NN to the NN RPC address after generic 
> keys have been configured. This should be done in all cases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to