[
https://issues.apache.org/jira/browse/HDFS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267817#comment-13267817
]
John George commented on HDFS-3350:
-----------------------------------
+1 The changes specifically related to this JIRA seem good to me. I just want
to understand the cleanups made a little better. Hence, could you explain why
the following changes were made?
{code}
- private synchronized void updatePermissionStatus(
- PermissionStatusFormat f, long n) {
+ private void updatePermissionStatus(PermissionStatusFormat f, long n) {
permission = f.combine(n, permission);
}
{code}
and
{code}
- public int hashCode() {
+ @Override
+ public final int hashCode() {
return Arrays.hashCode(this.name);
}
{code}
> findbugs warning: INodeFileUnderConstruction doesn't override
> INodeFile.equals(Object)
> --------------------------------------------------------------------------------------
>
> Key: HDFS-3350
> URL: https://issues.apache.org/jira/browse/HDFS-3350
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3350_20120502.patch, h3350_20120502b.patch
>
>
> Somehow this findbugs warning got triggered in the recent builds, e.g. [build
> #2361|https://builds.apache.org/job/PreCommit-HDFS-Build/2361/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html].
> It probably was triggered by HDFS-3339 although HDFS-3339 did not introduce
> the bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
