[ 
https://issues.apache.org/jira/browse/HDFS-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aaron T. Myers updated HDFS-3390:
---------------------------------

    Attachment: HDFS-3390.patch

Thanks a lot for the review, Nicholas.

The reason I did it the way I did in the original patch is that the DFSAdmin 
code currently has multiple separate catch blocks, and thus some code would 
need to be repeated in each one. In the attached patch, I've assigned the 
exception to a variable and only printed it out in one place at the end. I'm 
not sure I agree that this is much clearer, but I don't feel strongly about it. 
If you think this is better, then that's fine by me.

I strongly suspect that the test failures are unrelated to this patch.
                
> DFSAdmin should print full stack traces of errors when DEBUG logging is 
> enabled
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-3390
>                 URL: https://issues.apache.org/jira/browse/HDFS-3390
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs client
>    Affects Versions: 2.0.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Minor
>         Attachments: HDFS-3390.patch, HDFS-3390.patch
>
>
> If an error is encountered when running an `hdfs dfsadmin ...' command, only 
> the exception's message is output. It would be handy for debugging if the 
> full stack trace of the exception were output when DEBUG logging is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to