[ 
https://issues.apache.org/jira/browse/HDFS-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271454#comment-13271454
 ] 

Harsh J commented on HDFS-3358:
-------------------------------

bq. Should we include symlinks?

Instead of making it "X files, directories and symlinks" and given that 
symlinks are a purely optional usage, I'd prefer if we rather just printed "X 
inodes"

bq. Should we separate the counts for files, directories and symlinks?

This would be lovely to have instead of inode counts. Is there such metrics 
already available?

bq. Should we handle singular/plural? "1 blocks" does not look good.

Yes we should handle this. I'll update this logic in the patch I'll put up next.

bq Are there similar changes on the web UI?

Not sure I understood this one.

bq. We should also refactor the code, so that the same string is not 
constructed in two different places.

Agreed and will do.

Do lemme know thoughts on (1) and possibility of (2)!
                
> Specify explicitly that the NN UI status total is talking of persistent 
> objects on heap.
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-3358
>                 URL: https://issues.apache.org/jira/browse/HDFS-3358
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 2.0.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>              Labels: nitpick
>         Attachments: HDFS-3358.patch, HDFS-3358.patch
>
>
> The NN shows, on its web UI, something like:
> {{223 files and directories, 138 blocks = 361 total.}}
> Followed by heap stats.
> We should clarify this line is talking of objects and is related to the heap 
> summaries. Perhaps just being explicit about java-terms would be nicer:
> {{223 files and directories, 138 blocks = 361 total objects.}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to