[
https://issues.apache.org/jira/browse/HDFS-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272538#comment-13272538
]
Eli Collins commented on HDFS-3026:
-----------------------------------
Looks good. Two suggestions:
doImmediateShutdown is HA-specific (refers state transition and logs a specific
return code), how about making it take a return code and a message and
converting the 5 or so other places in NameNode where we do
{code}
LOG.error("something is wrong"); // or System.err etc
System.exit(<some code>);
{code}
with
{code}
doImmediateShutdown(<some code>, "something is wrong")
{code}
and can use another wrapper for the HA state transition case?
Noticed we don't check FS_TRASH_INTERVAL for bogus value, perhaps fail to start
the emptier if it's bogus and use a negative value in the test instead of
introducing failToStartTrashEmptierForTests?
> HA: Handle failure during HA state transition
> ---------------------------------------------
>
> Key: HDFS-3026
> URL: https://issues.apache.org/jira/browse/HDFS-3026
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha, name-node
> Affects Versions: 2.0.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Attachments: HDFS-3026-HDFS-1623.patch, HDFS-3026.patch
>
>
> This JIRA is to address a TODO in NameNode about handling the possibility of
> an incomplete HA state transition.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
