[ 
https://issues.apache.org/jira/browse/HDFS-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273516#comment-13273516
 ] 

Uma Maheswara Rao G commented on HDFS-3360:
-------------------------------------------

{code}
I think another good fix to make here would be to fix the variable substitution 
code to actually count depth of variable substitutions instead of just the 
count of variable substitutions. I'm under the impression that the MAX_SUBST is 
intended to prevent 20 recursive substitutions of a single config variable, and 
didn't consider the case when multiple replacements might all happen in a 
single value of a config var.
{code}
I too agree with you. The current code checks only total variable replacements 
it performed. Instead of that, each variable replacement itself should check 
recursively up to MAX_SUBST I feel. 
                
> SNN gets Shutdown if the conf "dfs.namenode.checkpoint.dir" and 
> "dfs.namenode.checkpoint.edits.dir" is configured to more than 6 comma 
> seperated values with 3-4 level in each directories
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3360
>                 URL: https://issues.apache.org/jira/browse/HDFS-3360
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.0.0, 3.0.0
>            Reporter: J.Andreina
>            Priority: Minor
>
> Configured "dfs.namenode.checkpoint.dir" and 
> "dfs.namenode.checkpoint.edits.dir" to more than 6 comma seperated 
> directories 
>  Started NN,DN,SNN
>  Secondary Namenode gets shutdown without throwing any exception
> But the descriptions says that "If this is a comma-delimited list of 
> directories then the image is
> replicated in all of the directories for redundancy."
> SNN logs
> ========
> {noformat}2012-04-26 13:08:37,534 INFO 
> org.apache.hadoop.hdfs.server.namenode.SecondaryNameNode: STARTUP_MSG: 
> /************************************************************
> STARTUP_MSG: Starting SecondaryNameNode
> STARTUP_MSG:   host = HOST-xx-xx-xx-xx/xx.xx.xx.xx
> STARTUP_MSG:   args = []
> STARTUP_MSG:   version = 2.0.0-SNAPSHOT
> STARTUP_MSG:   build =  -r ; compiled by 'isap' on Fri Apr 20 09:10:53 IST 
> 2012
> ************************************************************/
> 2012-04-26 13:08:38,728 INFO org.apache.hadoop.metrics2.impl.MetricsConfig: 
> loaded properties from hadoop-metrics2.properties
> 2012-04-26 13:08:38,861 INFO 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl: Scheduled snapshot period 
> at 10 second(s).
> 2012-04-26 13:08:38,861 INFO 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl: SecondaryNameNode metrics 
> system started
> 2012-04-26 13:08:39,176 INFO 
> org.apache.hadoop.hdfs.server.namenode.SecondaryNameNode: SHUTDOWN_MSG: 
> /************************************************************
> SHUTDOWN_MSG: Shutting down SecondaryNameNode at HOST-xx-xx-xx-xx/xx.xx.xx.xx
> ************************************************************/{noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to