[ 
https://issues.apache.org/jira/browse/HDFS-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276110#comment-13276110
 ] 

Eli Collins commented on HDFS-3418:
-----------------------------------

>From https://builds.apache.org/job/PreCommit-HDFS-Build/2442/console

{noformat}
+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12527370/hdfs-3418.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified test 
files.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.
{noformat}
                
> Rename BlockWithLocationsProto datanodeIDs field to storageIDs
> --------------------------------------------------------------
>
>                 Key: HDFS-3418
>                 URL: https://issues.apache.org/jira/browse/HDFS-3418
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-3418.txt, hdfs-3418.txt
>
>
> The "datanodeIDs" field in BlockWithLocationsProto is actually a list of 
> storageIDs. Let's rename it there and in BlocksWithLocations so the code is 
> clear.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to