[ 
https://issues.apache.org/jira/browse/HDFS-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon updated HDFS-2800:
------------------------------

    Attachment: hdfs-2800.txt

Take two.

I moved the cancellation "context" to be a standalone class instead of being 
part of SaveNamespaceContext. It can then be passed in from the 
StandbyCheckpointer thread, which eliminates the race mentioned in one of the 
TODO comments.

I looped this test for quite some time and wasn't able to get it to fail, with 
this patch applied.
                
> HA: TestStandbyCheckpoints.testCheckpointCancellation is racy
> -------------------------------------------------------------
>
>                 Key: HDFS-2800
>                 URL: https://issues.apache.org/jira/browse/HDFS-2800
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha, test
>    Affects Versions: 2.0.0
>            Reporter: Aaron T. Myers
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2800.txt, hdfs-2800.txt
>
>
> TestStandbyCheckpoints.testCheckpointCancellation is racy, have seen the 
> following assert on line 212 fail:
> {code}
> assertTrue(StandbyCheckpointer.getCanceledCount() > 0);
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to