[
https://issues.apache.org/jira/browse/HDFS-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282253#comment-13282253
]
Uma Maheswara Rao G commented on HDFS-3058:
-------------------------------------------
Patch looks pretty good to me.
Here is the concern:
{code}
try {
+ long id = currentLedger.getId();
currentLedger.close();
+ bkc.deleteLedger(id);
} catch (Exception e2) {
{code}
Instead deleting ledger alone, con't we delete inprogressNode first and on
success of deletion try to delete ledger? I think this is the point Rakesh
mentioned above.
+1 On addressing the above comment.
> HA: Bring BookKeeperJournalManager up to date with HA changes
> -------------------------------------------------------------
>
> Key: HDFS-3058
> URL: https://issues.apache.org/jira/browse/HDFS-3058
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 0.24.0
>
> Attachments: HDFS-3058.diff, HDFS-3058.diff, HDFS-3058.diff
>
>
> There's a couple of TODO(HA) comments in the BookKeeperJournalManager code.
> This JIRA is to address those.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
