[ 
https://issues.apache.org/jira/browse/HDFS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286466#comment-13286466
 ] 

Hadoop QA commented on HDFS-3423:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12530371/HDFS-3423.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified test 
files.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/2551//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2551//console

This message is automatically generated.
                
> BKJM: NN startup is failing, when tries to recoverUnfinalizedSegments() a bad 
> inProgress_ ZNodes
> ------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3423
>                 URL: https://issues.apache.org/jira/browse/HDFS-3423
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0
>            Reporter: Rakesh R
>            Assignee: Ivan Kelly
>         Attachments: HDFS-3423.diff, HDFS-3423.diff, HDFS-3423.diff, 
> HDFS-3423.patch, HDFS-3423.patch
>
>
> Say, the InProgress_000X node is corrupted due to not writing the 
> data(version, ledgerId, firstTxId) to this inProgress_000X znode. Namenode 
> startup has the logic to recover all the unfinalized segments, here will try 
> to read the segment and getting shutdown.
> {noformat}
> EditLogLedgerMetadata.java:
> static EditLogLedgerMetadata read(ZooKeeper zkc, String path)
>       throws IOException, KeeperException.NoNodeException  {
>       byte[] data = zkc.getData(path, false, null);
>       String[] parts = new String(data).split(";");
>       if (parts.length == 3)
>          ....reading inprogress metadata
>       else if (parts.length == 4)
>          ....reading inprogress metadata
>       else
>         throw new IOException("Invalid ledger entry, "
>                               + new String(data));
>       }
> {noformat}
> Scenario:- Leaving bad inProgress_000X node ?
> Assume BKJM has created the inProgress_000X zNode and ZK is not available 
> when trying to add the metadata. Now, inProgress_000X ends up with partial 
> information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to