[
https://issues.apache.org/jira/browse/HDFS-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289711#comment-13289711
]
Hadoop QA commented on HDFS-3446:
---------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530999/hdfs-3446.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified test
files.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/2596//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2596//console
This message is automatically generated.
> HostsFileReader silently ignores bad includes/excludes
> ------------------------------------------------------
>
> Key: HDFS-3446
> URL: https://issues.apache.org/jira/browse/HDFS-3446
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.0.0, 2.0.0-alpha
> Reporter: Matthew Jacobs
> Assignee: Matthew Jacobs
> Attachments: hdfs-3446.txt
>
>
> The HostsFileReader silently fails if the includes or excludes files do
> not exist or are not readable. The current behavior is to overwrite the
> existing set of hosts or excluded hosts, regardless of whether or not
> the includes/excludes file exists.
> This behavior was introduced in HADOOP-5643 to support updating the job
> tracker's node lists. The HostsFileReader is no longer used by the job
> tracker. If this behavior was intentional, it no longer seems necessary
> for any reason. The HostsFileReader is still used by NodeListManager as
> well as the DatanodeManager, and in both cases, throwing an exception
> when the include/exclude files aren't found/readable is desirable.
> We should validate the given includes and excludes files before using
> them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
