[
https://issues.apache.org/jira/browse/HDFS-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290579#comment-13290579
]
Colin Patrick McCabe commented on HDFS-3371:
--------------------------------------------
Currently, this code gets an NPE:
{code}
EditLogBackupInputStream elbis = new EditLogBackupInputStream(...);
elbis.close();
{code}
so that seems incorrect.
Also, if there are exceptions, you can't really assume that all of the streams
will exist in EditLogBackupInputStream#close.
Yeah, it's a minor nit, so it's really up to you guys whether it's worth it to
submit such a small fix. But I'd rather have it than not, personally.
> EditLogFileInputStream: be more careful about closing streams when we're done
> with them.
> ----------------------------------------------------------------------------------------
>
> Key: HDFS-3371
> URL: https://issues.apache.org/jira/browse/HDFS-3371
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3371.001.patch, HDFS-3371.002.patch
>
>
> EditLogFileInputStream#EditLogFileInputStream should be more careful about
> closing streams when there is an exception thrown. Also,
> EditLogFileInputStream#close should close all of the streams we opened in the
> constructor, not just one of them (although the file-backed one is probably
> the most important).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
