[ 
https://issues.apache.org/jira/browse/HDFS-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292121#comment-13292121
 ] 

Eli Collins commented on HDFS-3372:
-----------------------------------

Patch need to be rebased on trunk. Style nits:
- In the test the expected value should be the 1st argument to assertEquals
- No need to use "this" in Flags

Otherwise looks great.
                
> offlineEditsViewer should be able to read a binary edits file with recovery 
> mode
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-3372
>                 URL: https://issues.apache.org/jira/browse/HDFS-3372
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-3372.001.patch, HDFS-3372.002.patch, 
> HDFS-3372.003.patch
>
>
> It would be nice if oev (the offline edits viewer) had a switch that allowed 
> us to read a binary edits file using recovery mode.  oev can be very useful 
> when working with corrupt or messed up edit log files, and this would make it 
> even more so.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to