[
https://issues.apache.org/jira/browse/HDFS-3502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292838#comment-13292838
]
John George commented on HDFS-3502:
-----------------------------------
The patch looks good generally. A couple of questions:
Should we add {{Interface.Private}} above {{INodeFileUnderConstruction}} class?
The change in {{BlockInfo.java}} - I do not see {{EMPTY_ARRAY}} being used
anywhere - am I missing something?
{code}
+ public static final BlockInfo[] EMPTY_ARRAY = {};
{code}
> Change INodeFile and INodeFileUnderConstruction to package private
> ------------------------------------------------------------------
>
> Key: HDFS-3502
> URL: https://issues.apache.org/jira/browse/HDFS-3502
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3502_20120608.patch
>
>
> We already have BlockCollection and MutableBlockCollection interfaces so that
> INodeFile and INodeFileUnderConstruction can be changed to package private.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
