[
https://issues.apache.org/jira/browse/HDFS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294148#comment-13294148
]
Eli Collins commented on HDFS-3478:
-----------------------------------
+1 looks great Sujay
Style nits: these are copied from the other examples but fyi
- the catch should go on the same line as the preceding bracket eg "} catch
(IllegalArgumentException e) {"
- you can write the following more simply
{code}
hasException = false;
try {
dfs.setQuota(testFolder, Long.MAX_VALUE + 1, 10);
} catch (IllegalArgumentException e) {
hasException = true;
}
assertTrue("Excpetion not thrown", hasException);
{code}
as
{code}
try {
dfs.setQuota(testFolder, Long.MAX_VALUE + 1, 10);
fail("Exception not thrown");
} catch (IllegalArgumentException e) {
// Expected
}
{code}
Btw the current behavior comes from the following:
{code}
// Long that indicates "leave current quota unchanged"
public static final long QUOTA_DONT_SET = Long.MAX_VALUE;
{code}
> -setQuota, -setSpaceQuota Issues with Long.Max_Value
> ----------------------------------------------------
>
> Key: HDFS-3478
> URL: https://issues.apache.org/jira/browse/HDFS-3478
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Sujay Rau
> Assignee: Sujay Rau
> Priority: Minor
> Labels: newbie
> Attachments: hdfs-3478.txt
>
>
> [root@c1204 hadoop]# sudo -u hdfs hadoop fs -mkdir testQuotaFolder
> [root@c1204 hadoop]# sudo -u hdfs hadoop fs -count -q testQuotaFolder
> none inf none inf 1 0 0 testQuotaFolder
> [root@c1204 hadoop]# sudo -u hdfs hdfs dfsadmin -setQuota 1000 testQuotaFolder
> [root@c1204 hadoop]# sudo -u hdfs hdfs dfsadmin -setSpaceQuota 1000
> testQuotaFolder
> [root@c1204 hadoop]# sudo -u hdfs hadoop fs -count -q testQuotaFolder
> 1000 999 1000 1000 1 0 0 testQuotaFolder
> [root@c1204 hadoop]# sudo -u hdfs hdfs dfsadmin -setSpaceQuota
> 9223372036854775807 testQuotaFolder
> [root@c1204 hadoop]# sudo -u hdfs hdfs dfsadmin -setQuota 9223372036854775807
> testQuotaFolder
> [root@c1204 hadoop]# sudo -u hdfs hadoop fs -count -q testQuotaFolder
> 1000 999 1000 1000 1 0 0 testQuotaFolder
> [root@c1204 hadoop]# sudo -u hdfs hdfs dfsadmin -setQuota 9223372036854775806
> testQuotaFolder
> [root@c1204 hadoop]# sudo -u hdfs hdfs dfsadmin -setSpaceQuota
> 9223372036854775806 testQuotaFolder
> [root@c1204 hadoop]# sudo -u hdfs hadoop fs -count -q testQuotaFolder
> 9223372036854775806 9223372036854775805 9223372036854775806
> 9223372036854775806 1 0 0 testQuotaFolder
> The documentation at
> http://hadoop.apache.org/common/docs/r0.20.0/hdfs_quota_admin_guide.html says
> that the max quota size is Long.Max_Value which is = 9223372036854775807, but
> as you can see above, setting the quota to this value returns no error but
> doesn't actually change the quota value. Long.Max_Value - 1 works though.. so
> the documentation should be changed to reflect this behavior. Long.Max_Value
> + 1 returns an actual error (though it isn't the same as the negative number
> error):
> [root@c1204 hadoop]# sudo -u hdfs hdfs dfsadmin -setSpaceQuota
> 9223372036854775808 testQuotaFolder
> setSpaceQuota: For input string: "9223372036854775808"
> Usage: java DFSAdmin [-setSpaceQuota <quota> <dirname>...<dirname>]
> [root@c1204 hadoop]# sudo -u hdfs hdfs dfsadmin -setSpaceQuota -1
> testQuotaFolder
> setSpaceQuota: Illegal option -1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
