[ 
https://issues.apache.org/jira/browse/HDFS-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295954#comment-13295954
 ] 

Colin Patrick McCabe commented on HDFS-3521:
--------------------------------------------

bq. Let's keep our discussion on JIRA so that other people could comment on it. 
I have filed HDFS-3540 for this purpose.

Ok.  Since I noticed that there are a bunch of people watching this JIRA, but 
nobody watching HDFS-3540 (yet?), I hope you don't mind if I repost this 
comment twice.  I do apologize for the potential inbox spam.

I think rather than tolerating a configurable amount of edit log corruption, we 
should just never tolerate any corruption.

Basically, what I am saying is that UNCHECKED_REGION_LENGTH was a mistake.  It 
was my mistake, and I don't blame you for trying to fix it.  However, the 
current fix still assumes that there is someone who would want 
UNCHECKED_REGION_LENGTH.  I do not think any people like that exist!

Does that make sense?  I can post a patch if that would be helpful.
                
> Allow namenode to tolerate edit log corruption
> ----------------------------------------------
>
>                 Key: HDFS-3521
>                 URL: https://issues.apache.org/jira/browse/HDFS-3521
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 1.2.0
>
>         Attachments: h3521_20120610_b-1.patch, h3521_20120611_b-1.0.patch, 
> h3521_20120611_b-1.patch
>
>
> HDFS-3479 adds checking for edit log corruption. It uses a fixed 
> UNCHECKED_REGION_LENGTH (=PREALLOCATION_LENGTH) so that the bytes at the end 
> within the length is not checked.  Instead of not checking the bytes, we 
> should check everything and allow toleration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to