[
https://issues.apache.org/jira/browse/HDFS-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397256#comment-13397256
]
Junping Du commented on HDFS-3498:
----------------------------------
Nicholas, I will address naming enhancement when receiving your suggestion. On
the other hand, I found there are some usage of java container looks confusing
in code base like excludedNodes in chooseTargest(...), which is HashMap in
trunk and List in branch-1. I think the proper one is Set as we don't want the
element duplicated and don't care its sequence. There are also some other
examples on mis-usage of java container. Shall we address in this patch or
better to put in some separated JIRA?
> Make ReplicaPlacementPolicyDefault extensible for reuse code in subclass
> ------------------------------------------------------------------------
>
> Key: HDFS-3498
> URL: https://issues.apache.org/jira/browse/HDFS-3498
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 1.0.0, 2.0.0-alpha
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments: HDFS-3498-v2.patch, HDFS-3498.patch,
> Hadoop-8471-BlockPlacementDefault-extensible.patch
>
>
> ReplicaPlacementPolicy is already a pluggable component in Hadoop. A user
> specified ReplicaPlacementPolicy can be specified in the hdfs-site.xml
> configuration under the key "dfs.block.replicator.classname". However, to
> make it possible to reuse code in ReplicaPlacementPolicyDefault a few of its
> methods were changed from private to protected. ReplicaPlacementPolicy and
> BlockPlacementPolicyDefault are currently annotated with
> @InterfaceAudience.Private.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
