[ https://issues.apache.org/jira/browse/HDFS-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399761#comment-13399761 ]
Colin Patrick McCabe commented on HDFS-3510: -------------------------------------------- The "13 new javadoc warnings messages" are coming from RAID, it seems, not this patch {code} [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/Decoder. java:180: warning - @param argument "parityFile" is not a parameter name. [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/ DistRaidNode.java:58: warning - @inheritDocs is an unknown tag. [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/ DistRaidNode.java:71: warning - @inheritDocs is an unknown tag. [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/ DistRaidNode.java:58: warning - @inheritDocs is an unknown tag. [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/ DistRaidNode.java:58: warning - @inheritDocs is an unknown tag. [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/ DistRaidNode.java:71: warning - @inheritDocs is an unknown tag. [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/ DistRaidNode.java:71: warning - @inheritDocs is an unknown tag. [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/Encoder. java:340: warning - @param argument "srcFile" is not a parameter name. [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/ RaidConfigurationException.java:24: warning - Tag @link: reference not found: CronNode [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/ RaidConfigurationException.java:24: warning - Tag @link: reference not found: CronNode [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/ DistRaidNode.java:58: warning - @inheritDocs is an unknown tag. [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/ RaidConfigurationException.java:24: warning - Tag @link: reference not found: CronNode [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-raid/src/main/java/org/apache/hadoop/raid/ DistRaidNode.java:71: warning - @inheritDocs is an unknown tag. {code} > Improve FSEditLog pre-allocation > -------------------------------- > > Key: HDFS-3510 > URL: https://issues.apache.org/jira/browse/HDFS-3510 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 1.0.0, 2.0.0-alpha > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Fix For: 1.0.0, 2.0.1-alpha > > Attachments: HDFS-3510-b1.001.patch, HDFS-3510-b1.002.patch, > HDFS-3510.001.patch, HDFS-3510.003.patch, HDFS-3510.004.patch, > HDFS-3510.004.patch, HDFS-3510.006.patch, HDFS-3510.007.patch, > HDFS-3510.008.patch, HDFS-3510.009.patch, HDFS-3510.010.patch > > > It is good to avoid running out of space in the middle of writing a batch of > edits, because when it happens, we often get partial edits at the end of the > log. > Edit log preallocation can solve this problem (see HADOOP-2330 for a full > description of edit log preallocation). > The current pre-allocation code was introduced for performance reasons, not > for preventing partial edits. As a consequence, we sometimes do a write > without using pre-allocation. We should change the pre-allocation code so > that it always preallocates at least enough space before writing out the > edits. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira