[
https://issues.apache.org/jira/browse/HDFS-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400055#comment-13400055
]
Eli Collins commented on HDFS-3481:
-----------------------------------
Looks good
- Is the reason you're introducing the Parameters class vs using a Map directly
because you plan to add other members/methods?
- Wrt the code that's generating a warning why not use guava's immutable map?
{code}
static final Map<String, String> M = ImmutableMap.of(
"k1", "v1",
"k2", "v2"
);
{code}
- Please remove following, other similar changes
{code}
return Arrays.asList(ops);
// return Arrays.asList(new Object[][]{ new Object[]{Operation.CREATE}});
{code}
> Refactor HttpFS handling of JAX-RS query string parameters
> ----------------------------------------------------------
>
> Key: HDFS-3481
> URL: https://issues.apache.org/jira/browse/HDFS-3481
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.1-alpha
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3481.patch, HDFS-3481.patch
>
>
> Explicit parameters in the HttpFSServer became quite messy as they are the
> union of all possible parameters for all operations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
