[
https://issues.apache.org/jira/browse/HDFS-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401037#comment-13401037
]
Aaron T. Myers commented on HDFS-3559:
--------------------------------------
Patch looks really good to me. Just a few little nits:
# I think doing "public static class" is a little more common than "static
public class" throughout the project.
# Seems like the instance vars in DFSTestUtil can reasonably be made final.
+1 once these are addressed.
> DFSTestUtil: use Builder class to construct DFSTestUtil instances
> -----------------------------------------------------------------
>
> Key: HDFS-3559
> URL: https://issues.apache.org/jira/browse/HDFS-3559
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3559.001.patch
>
>
> The number of parameters in DFSTestUtil's constructor has grown over time.
> It would be nice to have a Builder class similar to MiniDFSClusterBuilder,
> which could construct an instance of DFSTestUtil.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
