[
https://issues.apache.org/jira/browse/HDFS-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J updated HDFS-3475:
--------------------------
Attachment: HDFS-3475.patch
Updated patch addresses Aaron's comments and also adds in checks for value
being {{-gt zero}}.
Both tests mentioned pass for me locally with and without patch applied. Was
something on trunk at the time possibly, its gone now.
[With patch applied]
{code}
-------------------------------------------------------
T E S T S
-------------------------------------------------------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.581 sec
Running org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
gTests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.291 sec
{code}
Thanks Aaron. After a Jenkins +1 on this new patch, I shall commit it in,
unless you have further comments on the patch.
> Make the replication monitor multipliers configurable
> -----------------------------------------------------
>
> Key: HDFS-3475
> URL: https://issues.apache.org/jira/browse/HDFS-3475
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Attachments: HDFS-3475.patch, HDFS-3475.patch, HDFS-3475.patch
>
>
> BlockManager currently hardcodes the following two constants:
> {code}
> private static final int INVALIDATE_WORK_PCT_PER_ITERATION = 32;
> private static final int REPLICATION_WORK_MULTIPLIER_PER_ITERATION = 2;
> {code}
> These are used to throttle/limit the amount of deletion and
> replication-to-other-DN work done per heartbeat interval of a live DN.
> Not many have had reasons to want these changed so far but there have been a
> few requests I've faced over the past year from a variety of clusters I've
> helped maintain. I think with the improvements in disks and network thats
> already started to be rolled out in production environments out there,
> changing these may start making sense to some.
> Lets at least make it advanced-configurable with proper docs that warn
> adequately, with the defaults being what they are today. With hardcodes, it
> comes down to a recompile for admins, which is not something they may like.
> Please let me know your thoughts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
