[ 
https://issues.apache.org/jira/browse/HDFS-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403206#comment-13403206
 ] 

Brandon Li commented on HDFS-3576:
----------------------------------

{quote}This patch appears to have just shifted the hardcoded value. Would it 
maybe be cleaner to have a Namenode.getDefaultPort() to return the value? That 
would provided a single point of change in case we actually want to obtain the 
default port from the conf as is done for other ports.{quote}
Daryn, thanks for looking into the patch. Since it is the "default" port, it 
doesn't need to be configured in conf. DFSConfigKeys has become the place to 
save this kind of configuration constants. Not sure if I answered your question.

                
> create a configuration key for NameNode default RPC port
> --------------------------------------------------------
>
>                 Key: HDFS-3576
>                 URL: https://issues.apache.org/jira/browse/HDFS-3576
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Minor
>         Attachments: HDFS-3576.patch
>
>
> Currently the default rpc port (8020) is hard coded in NameNode.java, which 
> makes it inconvenient to locate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to