[ 
https://issues.apache.org/jira/browse/HDFS-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colin Patrick McCabe updated HDFS-3539:
---------------------------------------

    Attachment: HDFS-3539.003.patch

* libhdfs.h: only include the header files we need.  Including extra header 
files slows down compilation and may complicate matters for library users.

* libhdfs.h: we don't need tTime, a typedef to a type that is itself a typedef, 
time_t.  Just use int64_t, which reflects the fact that HDFS deals with time as 
a 64-bit number.  (Note that time_t is 64 bits on most modern systems, but we 
shouldn't be relying on that.)

* do not expose the fields of hdfsFile_internal in the header file.  Instead, 
offer accessors to things that might be interesting to library users, like 
whether a file is open for read, open for write, using direct read, etc.

* set LIBHDFS_VERSION to 1.0.0
                
> libhdfs code cleanups
> ---------------------
>
>                 Key: HDFS-3539
>                 URL: https://issues.apache.org/jira/browse/HDFS-3539
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-3539.001.patch, HDFS-3539.002.patch, 
> HDFS-3539.003.patch
>
>
> Fix some compiler warnings, improperly exposed private data types, and 
> extraneous includes in libhdfs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to