[ 
https://issues.apache.org/jira/browse/HDFS-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409800#comment-13409800
 ] 

Harsh J commented on HDFS-3617:
-------------------------------

{code}

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 2 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     -1 findbugs.  The patch appears to introduce 218 new Findbugs 
(version 2.0.1-rc3) warnings.
{code}

Findbugs seem unrelated to me. Quick scan through report shows nothing from my 
lines at least.
                
> Port HDFS-96 to branch-1 (support blocks greater than 2GB)
> ----------------------------------------------------------
>
>                 Key: HDFS-3617
>                 URL: https://issues.apache.org/jira/browse/HDFS-3617
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 1.0.3
>            Reporter: Matt Foley
>            Assignee: Harsh J
>         Attachments: HDFS-3617.patch
>
>
> Please see HDFS-96.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to