[
https://issues.apache.org/jira/browse/HDFS-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410728#comment-13410728
]
Harsh J commented on HDFS-3613:
-------------------------------
Thanks Andrew!
This looks good, just one nit: Please wrap all LOG.debug performing lines under
an {{if (LOG.isDebugEnabled()) { }}} check, to stay consistent with the rest of
the code base (it is for a performance reason, check out HADOOP-6884 if you
want to have some historical reading).
> GSet prints some INFO level values, which aren't really very useful to all
> --------------------------------------------------------------------------
>
> Key: HDFS-3613
> URL: https://issues.apache.org/jira/browse/HDFS-3613
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Harsh J
> Assignee: Andrew Wang
> Priority: Trivial
> Labels: newbie
> Attachments: hdfs-3613.patch
>
>
> The following has long been seen in NameNode but I have never seen it being
> valued by anyone other than a HDFS developer:
> {code}
> 12/07/08 20:00:22 INFO util.GSet: VM type = 64-bit
> 12/07/08 20:00:22 INFO util.GSet: 2% max memory = 19.75 MB
> 12/07/08 20:00:22 INFO util.GSet: capacity = 2^21 = 2097152 entries
> 12/07/08 20:00:22 INFO util.GSet: recommended=2097152, actual=2097152
> {code}
> Lets switch it down to DEBUG.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
