[ 
https://issues.apache.org/jira/browse/HDFS-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410930#comment-13410930
 ] 

Aaron T. Myers commented on HDFS-3583:
--------------------------------------

The script looks pretty good to me. One thing I think it missed: JUnit 4 has 
support for @BeforeClass and @AfterClass annotations, to indicate that static 
methods should be run once before/after a whole test class. JUnit 3 has an 
analog that a few of the tests use, which we'll have to take care of. See this 
SO question for more info: 
http://stackoverflow.com/questions/7208593/how-can-i-get-beforeclass-and-afterclass-equivalent-in-junit3
                
> Convert remaining tests to Junit4
> ---------------------------------
>
>                 Key: HDFS-3583
>                 URL: https://issues.apache.org/jira/browse/HDFS-3583
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Andrew Wang
>              Labels: newbie
>         Attachments: junit3to4.sh
>
>
> JUnit4 style tests are easier to debug (eg can use @Timeout etc), let's 
> convert the remaining tests over to Junit4 style.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to