[ 
https://issues.apache.org/jira/browse/HDFS-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414092#comment-13414092
 ] 

Daryn Sharp commented on HDFS-3654:
-----------------------------------

I like the new {{NameNode#verifyToken}}, but it does a synchronized invocation 
of {{namesystem.getDelegationTokenSecretManager().verifyToken}}.  There's an 
existing synchronized {{FSNameSystem#verifyToken}}.  You may want to streamline 
all of them.  I'd lean towards eliminating the {{FSNameSystem#verifyToken}} 
since it only appears to be called by {{JspHelper#getUGI}}.
                
> TestJspHelper#testGetUgi may fail
> ---------------------------------
>
>                 Key: HDFS-3654
>                 URL: https://issues.apache.org/jira/browse/HDFS-3654
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.1-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-3654-b1.txt, hdfs-3654.txt
>
>
> Looks like my recent change in HDFS-3639 can occasionally cause this test to 
> fail. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to