[
https://issues.apache.org/jira/browse/HDFS-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417074#comment-13417074
]
Daryn Sharp commented on HDFS-3639:
-----------------------------------
To avoid possible duplication of code, perhaps add a boolean to the method
signature for whether to verify the token? Or maybe pass in the NN object or
null to indicate whether to verify the token?
> JspHelper#getUGI should always verify the token if security is enabled
> ----------------------------------------------------------------------
>
> Key: HDFS-3639
> URL: https://issues.apache.org/jira/browse/HDFS-3639
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
> Affects Versions: 1.0.0, 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hdfs-3639-b1.txt, hdfs-3639.txt
>
>
> JspHelper#getUGI on verifies the given token if the context and nn are set
> (added in HDFS-2416). We should unconditionally verifyToken the token, ie a
> bug where "name.node" is not set in the context object should not result in
> not verifying the token. In practice this shouldn't be an issue as per
> HDFS-3434 the context and NN should never be null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira