[ https://issues.apache.org/jira/browse/HDFS-3693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421671#comment-13421671 ]
Aaron T. Myers commented on HDFS-3693: -------------------------------------- One tiny nit, you might want to put a space after ":" here: {code} System.err.println("storage string:" + storageString); {code} Otherwise the patch looks good to me. +1. > QJM: JNStorage should read its storage info even before a writer becomes > active > ------------------------------------------------------------------------------- > > Key: HDFS-3693 > URL: https://issues.apache.org/jira/browse/HDFS-3693 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: QuorumJournalManager (HDFS-3077) > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Minor > Attachments: hdfs-3693.txt > > > In order for QJM to work with HA, the standby needs to be able to read from a > JournalNode even when no active has written to it. In the current code, it > reads the StorageInfo only when {{newEpoch()}} is called. But, that's only > called when a writer becomes active. This causes the SBN to fail at startup > since the JN thinks its storage info is uninitialized. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira