[ 
https://issues.apache.org/jira/browse/HDFS-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423573#comment-13423573
 ] 

Aaron T. Myers commented on HDFS-3650:
--------------------------------------

The latest patch looks great to me, Andrew. One tiny nit: in 
testRoundTripAckMetric in one place you do a "assertTrue(x != null)". Instead 
of this, you can just do "assertNotNull(x)".

+1 once this is addressed.
                
> Use MutableQuantiles to provide latency histograms for various operations
> -------------------------------------------------------------------------
>
>                 Key: HDFS-3650
>                 URL: https://issues.apache.org/jira/browse/HDFS-3650
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-3650-1.patch, hdfs-3650-2.patch
>
>
> MutableQuantiles provide accurate estimation of various percentiles for a 
> stream of data. Many existing metrics reported by a MutableRate would also 
> benefit from having these percentiles; lets add MutableQuantiles where we 
> think it'd be useful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to