[ 
https://issues.apache.org/jira/browse/HDFS-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431392#comment-13431392
 ] 

Todd Lipcon commented on HDFS-3765:
-----------------------------------

Seems it's not passing its unit tests. I think the code needs to look like this 
instead:
{code}
        newSharedEditLog.logEdit(op);

        if (op.opCode == FSEditLogOpCodes.OP_END_LOG_SEGMENT) {
          newSharedEditLog.endCurrentLogSegment(true);
          break;
        }
{code}

Otherwise the END_LOG_SEGMENT transaction doesn't end up logged in shared 
edits, and you end up with a one-op gap in between every segment.
                
> Namenode INITIALIZESHAREDEDITS should be able to initialize all shared 
> storages
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-3765
>                 URL: https://issues.apache.org/jira/browse/HDFS-3765
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: ha
>    Affects Versions: 2.1.0-alpha, 3.0.0
>            Reporter: Vinay
>            Assignee: Vinay
>         Attachments: HDFS-3765.patch, HDFS-3765.patch
>
>
> Currently, NameNode INITIALIZESHAREDEDITS provides ability to copy the edits 
> files to file schema based shared storages when moving cluster from Non-HA 
> environment to HA enabled environment.
> This Jira focuses on the following
> * Generalizing the logic of copying the edits to new shared storage so that 
> any schema based shared storage can initialized for HA cluster.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to