[
https://issues.apache.org/jira/browse/HDFS-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433527#comment-13433527
]
Todd Lipcon commented on HDFS-3276:
-----------------------------------
Hudson built this here: https://builds.apache.org/job/PreCommit-HDFS-Build/2983/
but the comment was swallowed during JIRA downtime:
{quote}
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12540156/hdfs-3276.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
+1 contrib tests. The patch passed contrib unit tests.
{quote}
Looking into the new findbugs warnings.
> initializeSharedEdits should have a -nonInteractive flag
> --------------------------------------------------------
>
> Key: HDFS-3276
> URL: https://issues.apache.org/jira/browse/HDFS-3276
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ha, name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Vinithra Varadharajan
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hdfs-3276.txt
>
>
> Similar to format and bootstrapStandby, would be nice to have -nonInteractive
> as an option on initializeSharedEdits
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
