[ 
https://issues.apache.org/jira/browse/HDFS-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436141#comment-13436141
 ] 

Eli Collins commented on HDFS-3788:
-----------------------------------

bq. I think we don't have a standard in our code for this kind of style. So I 
will leave them as-is.

All the surrounding conditionals and loops have spaces, as does the vast 
majority of the rest of the code base, including the new code you're adding in 
this patch. Good to be consistent even within your own patches right?

Otherwise +1  looks great
                
> distcp can't copy large files using webhdfs due to missing Content-Length 
> header
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-3788
>                 URL: https://issues.apache.org/jira/browse/HDFS-3788
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: webhdfs
>    Affects Versions: 0.23.3, 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Critical
>         Attachments: 20120814NullEntity.patch, distcp-webhdfs-errors.txt, 
> h3788_20120813.patch, h3788_20120814b.patch, h3788_20120814.patch, 
> h3788_20120815.patch
>
>
> The following command fails when data1 contains a 3gb file. It passes when 
> using hftp or when the directory just contains smaller (<2gb) files, so looks 
> like a webhdfs issue with large files.
> {{hadoop distcp webhdfs://eli-thinkpad:50070/user/eli/data1 
> hdfs://localhost:8020/user/eli/data2}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to