[ 
https://issues.apache.org/jira/browse/HDFS-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440088#comment-13440088
 ] 

Rakesh R commented on HDFS-3810:
--------------------------------

@Ivan
Looks good apart from the following thoughts.
- Better, would use org.apache.zookeeper.ZKUtil.deleteRecursive(ZooKeeper zk, 
final String pathRoot) for deleting zkc.getChildren(basePath, false); instead 
of iterating through children
- BTW, I was thinking about the concurrent/consecutive NN formatting. Its good 
to have one testcase showing concurrent/consecutive formatting behaviour. Here 
one would success and other would get exception. I mean the testcase can show 
even after the exception, BKJM should continue without any problem.


                
> Implement format() for BKJM
> ---------------------------
>
>                 Key: HDFS-3810
>                 URL: https://issues.apache.org/jira/browse/HDFS-3810
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: HDFS-3810.diff
>
>
> At the moment, formatting for BKJM is done on initialization. Reinitializing 
> is a manual process. This JIRA is to implement the JournalManager#format API, 
> so that BKJM can be formatting along with all other storage methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to