[
https://issues.apache.org/jira/browse/HDFS-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442214#comment-13442214
]
Brandon Li commented on HDFS-3855:
----------------------------------
test-patch result:
{noformat}
-1 overall.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 195 new Findbugs (version
2.0.0) warnings.
{noformat}
No new unit test is needed for string replacement, and the patch doesn't
introduce new findbugs warnings.
> Replace hardcoded strings with the already defined config keys in
> DataNode.java
> --------------------------------------------------------------------------------
>
> Key: HDFS-3855
> URL: https://issues.apache.org/jira/browse/HDFS-3855
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 1.2.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Trivial
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
