[
https://issues.apache.org/jira/browse/HDFS-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444248#comment-13444248
]
Suresh Srinivas commented on HDFS-3837:
---------------------------------------
Other than findbugs exclude, rest of the changes do not seem necessary or adds
value. My preference is to undo it. However I do not feel strongly about this.
+1 for the patch.
> Fix DataNode.recoverBlock findbugs warning
> ------------------------------------------
>
> Key: HDFS-3837
> URL: https://issues.apache.org/jira/browse/HDFS-3837
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-3837.txt, hdfs-3837.txt, hdfs-3837.txt,
> hdfs-3837.txt
>
>
> HDFS-2686 introduced the following findbugs warning:
> {noformat}
> Call to equals() comparing different types in
> org.apache.hadoop.hdfs.server.datanode.DataNode.recoverBlock(BlockRecoveryCommand$RecoveringBlock)
> {noformat}
> Both are using DatanodeID#equals but it's a different method because
> DNR#equals overrides equals for some reason (doesn't change behavior).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
