[ 
https://issues.apache.org/jira/browse/HDFS-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446386#comment-13446386
 ] 

Robert Joseph Evans commented on HDFS-3873:
-------------------------------------------

It looks good to me.  I am not really an expert on HFTP, but this is a simple 
enough change that I feel OK to give it a +1, but please use your discretion 
before checking it in.

I am not sure why Jenkins ran the tests again and they failed, but when I run 
them with your patch they pass. except for TestHftpDelegationToken which is a 
known issue.
                
> Hftp assumes security is disabled if token fetch fails
> ------------------------------------------------------
>
>                 Key: HDFS-3873
>                 URL: https://issues.apache.org/jira/browse/HDFS-3873
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.23.3, 3.0.0, 2.2.0-alpha
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-3873.branch-23.patch, HDFS-3873.patch
>
>
> Hftp ignores all exceptions generated while trying to get a token, based on 
> the assumption that it means security is disabled.  Debugging problems is 
> excruciatingly difficult when security is enabled but something goes wrong.  
> Job submissions succeed, but tasks fail because the NN rejects the user as 
> unauthenticated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to