[
https://issues.apache.org/jira/browse/HDFS-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447426#comment-13447426
]
Todd Lipcon commented on HDFS-3869:
-----------------------------------
Added the following comment:
{code}
+ // COW implementation is necessary since some users (eg the web ui) call
+ // getAllJournalStreams() and then iterate. Since this is rarely
+ // mutated, there is no performance concern.
private List<JournalAndStream> journals =
new CopyOnWriteArrayList<JournalSet.JournalAndStream>();
{code}
I also realized that the method had a @VisibleForTesting annotation which was
no longer true, so I removed that.
Will commit momentarily with the above change.
> QJM: expose non-file journal manager details in web UI
> ------------------------------------------------------
>
> Key: HDFS-3869
> URL: https://issues.apache.org/jira/browse/HDFS-3869
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: QuorumJournalManager (HDFS-3077)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: dir-failed.png, hdfs-3869.txt, hdfs-3869.txt,
> lagging-jn.png, open-for-read.png, open-for-write.png
>
>
> Currently, the NN web UI only contains NN storage directories on local disk.
> It should also include details about any non-file JournalManagers in use.
> This JIRA targets the QJM branch, but will be useful for BKJM as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
